fix: Properly resubscribe to nested prop changes #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazo0
changed the title
rajamatt
approved these changes
Jun 22, 2023
agneszitte
approved these changes
Jun 22, 2023
|
https://github.com/Mergifyio backport legacy/3x
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
* fix: Properly resubscribe to nested prop changes * chore: whitespace * chore: whitespace (cherry picked from commit 8f4a08f) # Conflicts: # src/Uno.Toolkit.RuntimeTests/Tests/NavigationBarTests.cs
agneszitte
pushed a commit
that referenced
this pull request
Aug 7, 2023
* fix: Properly resubscribe to nested prop changes * chore: whitespace * chore: whitespace (cherry picked from commit 8f4a08f) # Conflicts: # src/Uno.Toolkit.RuntimeTests/Tests/NavigationBarTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #381
fixes #623
PR Type
What kind of change does this PR introduce?
When a property would change at runtime, the logic to re-register to the nested property callback was incorrectly using the
senderinstead of the actual owner of the sub-properties