Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Lightweight Styling] Fix XAML/Screenshot sample #783

Closed
kazo0 opened this issue Aug 30, 2023 · 3 comments · Fixed by #799, #800 or #801
Closed

[Docs][Lightweight Styling] Fix XAML/Screenshot sample #783

kazo0 opened this issue Aug 30, 2023 · 3 comments · Fixed by #799, #800 or #801
Assignees
Labels
area/lightweight-styling kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification.

Comments

@kazo0
Copy link
Contributor

kazo0 commented Aug 30, 2023

image

The XAML does not fully match with the screenshot of the chips, we should show the xaml for the Default chip as well and have an example of the Overridden chip without the pointer over state so we can see all lightweight styling resource overrides at work

@kazo0 kazo0 added kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification. area/lightweight-styling labels Aug 30, 2023
@kazo0 kazo0 self-assigned this Aug 30, 2023
@carlh98
Copy link
Contributor

carlh98 commented Sep 1, 2023

image
image
@kazo0

@kazo0
Copy link
Contributor Author

kazo0 commented Sep 1, 2023

@carlh98

  1. Let's split the xaml into three separate Chips, one Default, one Overridden like the Green one, and then a separate one that has the PointerOver resources overridden
  2. Change the "Overriden" to "Overridden"
  3. You can just provide the code block of the XAML here instead of a screenshot, that way I can copy paste it into the docs and the release blog post
  4. Let's remove the explicit Style setter for FilterChipStyle

So something like this:

<StackPanel>
	<utu:Chip Content="Default Chip Style" />
	
	<utu:Chip Content="Overridden Chip Style">
		<utu:Chip.Resources>
			<SolidColorBrush x:Key="ChipForeground" Color="DarkGreen" />
			<SolidColorBrush x:Key="ChipBackground" Color="LightGreen" />
			<SolidColorBrush x:Key="ChipBorderBrush" Color="DarkGreen" />
		</utu:Chip.Resources>
	</utu:Chip>
	
	<utu:Chip Content="Overridden Chip Style (PointerOver)">
		<utu:Chip.Resources>
			<SolidColorBrush x:Key="ChipForegroundPointerOver" Color="DarkRed" />
			<SolidColorBrush x:Key="ChipBackgroundPointerOver" Color="LightPink" />
			<SolidColorBrush x:Key="ChipBorderBrushPointerOver" Color="DarkRed" />
		</utu:Chip.Resources>
	</utu:Chip>
</StackPanel>

@agneszitte
Copy link
Contributor

Re-Open for backport PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lightweight-styling kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
4 participants