Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponsiveLayout as static resource #945

Closed
kazo0 opened this issue Dec 4, 2023 · 0 comments · Fixed by #944
Closed

ResponsiveLayout as static resource #945

kazo0 opened this issue Dec 4, 2023 · 0 comments · Fixed by #944
Assignees
Labels
control/responsive Categorizes an issue or PR as relevant to Responsive-View,-Expression, or -Helper

Comments

@kazo0
Copy link
Contributor

kazo0 commented Dec 4, 2023

The RespsoniveLayout class from the ResponsiveHelper should be kept as a static resource where it can be overridden at any level to change the default layout breakpoint values

The ResponsiveView and Responsive markup extension should resolve the resources from an agreed upon default key, something like DefaultResponsiveLayout, and use those values for its breakpoints

@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. control/responsive Categorizes an issue or PR as relevant to Responsive-View,-Expression, or -Helper and removed kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Dec 4, 2023
@Xiaoy312 Xiaoy312 self-assigned this Dec 4, 2023
@Xiaoy312 Xiaoy312 mentioned this issue Dec 4, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control/responsive Categorizes an issue or PR as relevant to Responsive-View,-Expression, or -Helper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants