Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadowContainer] Inner Shadows not properly fitted in Rectangle and Ellipse #757

Merged
merged 9 commits into from
Aug 30, 2023
Merged

[ShadowContainer] Inner Shadows not properly fitted in Rectangle and Ellipse #757

merged 9 commits into from
Aug 30, 2023

Conversation

rafael-rosa-knowcode
Copy link
Contributor

@rafael-rosa-knowcode rafael-rosa-knowcode commented Aug 24, 2023 •
edited by Xiaoy312
Loading

GitHub Issue (If applicable): closes #740, closes #735
closes #769 (this pr will replace that one)

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Inner Shadows not properly fitted in Rectangle and Ellipse:
image

What is the new behavior?

Complex shape and uneven corner-radius support:
image

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

n/a

@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

agneszitte
agneszitte reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this please :)

@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue740-EllipseInnerShadow branch from e6eaa79 to d9878b3 Compare August 25, 2023 14:49
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 26, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue740-EllipseInnerShadow branch from c6a2599 to 97472ea Compare August 29, 2023 17:50
@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue740-EllipseInnerShadow branch from 97472ea to 4776e37 Compare August 29, 2023 19:09
@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/3x release/stable/3.1

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023 •
edited
Loading

backport legacy/3x release/stable/3.1

✅ Backports have been created

@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/ramr/issue740-EllipseInnerShadow branch from 991f957 to 8a9b1ff Compare August 29, 2023 23:38
@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@agneszitte agneszitte mentioned this pull request Aug 30, 2023
Closed
18 tasks
@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue740-EllipseInnerShadow branch from 4f19f8f to b88d27c Compare August 30, 2023 16:32
@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-757.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit ff48082 into main Aug 30, 2023
24 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/ramr/issue740-EllipseInnerShadow branch August 30, 2023 20:04
This was referenced Aug 30, 2023
Merged
Merged
@rafael-rosa-knowcode rafael-rosa-knowcode mentioned this pull request Aug 30, 2023
Closed
11 tasks
agneszitte pushed a commit that referenced this pull request Aug 30, 2023
@mergify @RafaelMendesRosa @Xiaoy312
[ShadowContainer] Inner Shadows not properly fitted in Rectangle and …
5e9d661 
…Ellipse (backport #757) (#787)

Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: xiaoy312 <xiaoyao312@gmail.com>
agneszitte pushed a commit that referenced this pull request Aug 30, 2023
@mergify @RafaelMendesRosa @Xiaoy312
[ShadowContainer] Inner Shadows not properly fitted in Rectangle and …
9d59ba1 
…Ellipse (backport #757) (#786)

Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: xiaoy312 <xiaoyao312@gmail.com>
@Xiaoy312 Xiaoy312 mentioned this pull request Sep 5, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@agneszitte agneszitte agneszitte approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@roubachof roubachof Awaiting requested review from roubachof

@kazo0 kazo0 Awaiting requested review from kazo0

@carldebilly carldebilly Awaiting requested review from carldebilly

Assignees
No one assigned
Labels
control/shadows
Projects
None yet
Milestone
No milestone
5 participants
@rafael-rosa-knowcode @agneszitte @jeromelaban @Xiaoy312 @RafaelMendesRosa