Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadowContainer] Non uniform corner radius support #735

Closed
roubachof opened this issue Aug 18, 2023 · 2 comments · Fixed by #757, #786 or #787
Closed

[ShadowContainer] Non uniform corner radius support #735

roubachof opened this issue Aug 18, 2023 · 2 comments · Fixed by #757, #786 or #787
Assignees
@rafael-rosa-knowcode
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.

Comments

@roubachof
Copy link
Contributor

For now it only supports uniform corner radius. We should be able to support different corner radii with https://learn.microsoft.com/en-us/dotnet/api/skiasharp.skroundrect.setrectradii?view=skiasharp-2.88
@roubachof roubachof added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Aug 18, 2023
@eriklimakc
Copy link
Contributor

Using Grid with CornerRadius="20,0,0,20" I could repro with Inner Shadows as follows:

1st Grid without shadows
2nd Grid with Drop shadows
3rd Grid with Inner shadows

image

Repro -> NonUniformRadius.zip

This was referenced Aug 24, 2023
Closed
Closed
@Xiaoy312 Xiaoy312 mentioned this issue Aug 29, 2023
Merged
18 tasks
@agneszitte
Copy link
Contributor

Re-Open for backports

@agneszitte agneszitte reopened this Aug 30, 2023
This was linked to pull requests Aug 30, 2023
[ShadowContainer] Inner Shadows not properly fitted in Rectangle and Ellipse (backport #757) #786
Merged
[ShadowContainer] Inner Shadows not properly fitted in Rectangle and Ellipse (backport #757) #787
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafael-rosa-knowcode rafael-rosa-knowcode

Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
5 participants
@roubachof @Xiaoy312 @agneszitte @eriklimakc @rafael-rosa-knowcode