Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadowContainer] CornerRadius performance issue #790

Merged
merged 6 commits into from
Sep 14, 2023
Merged

[ShadowContainer] CornerRadius performance issue #790

merged 6 commits into from
Sep 14, 2023

Conversation

rafael-rosa-knowcode
Copy link
Contributor

@rafael-rosa-knowcode rafael-rosa-knowcode commented Aug 30, 2023 •
edited
Loading

GitHub Issue (If applicable): closes: #789

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

For better performance.

What is the new behavior?

Using array.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

agneszitte
agneszitte reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add tests with this PR please ;)

@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-790.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-790.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-790.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-790.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-790.eastus2.azurestaticapps.net

@rafael-rosa-knowcode
Copy link
Contributor Author

rafael-rosa-knowcode commented Sep 14, 2023 •
edited
Loading

@jeromelaban @agneszitte @kazo0

During testing on wasm.
I noticed that the ImageAssertHelper.IsScreenshotSupported validation takes into account whether Microsoft.UI.Xaml.Media.Imaging.RenderTargetBitmap is implemented.
And it presents the false result.
However it works locally, even within the WinUI project.

When the validation is present the test shows Inconclusive.

image

When the validation is removed the test works fine on wasm.

image

In this case, we keep ImageAssertHelper.IsScreenshotSupported()?

Edit:
I created a issue #843
And will close this one.

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-790.eastus2.azurestaticapps.net

@rafael-rosa-knowcode rafael-rosa-knowcode mentioned this pull request Sep 14, 2023
Open
11 tasks
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/3x release/stable/4.2

@agneszitte agneszitte merged commit 50eed77 into main Sep 14, 2023
24 checks passed
@agneszitte agneszitte deleted the dev/ramr/issue789 branch September 14, 2023 19:44
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023 •
edited
Loading

backport legacy/3x release/stable/4.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@rafael-rosa-knowcode @mergify
[ShadowContainer] CornerRadius performance issue (#790)
b257169 
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
(cherry picked from commit 50eed77)

# Conflicts:
#	build/workflow/stage-uitests-ios.yml
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@rafael-rosa-knowcode @mergify
[ShadowContainer] CornerRadius performance issue (#790)
c35a74d 
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
(cherry picked from commit 50eed77)

# Conflicts:
#	build/workflow/stage-uitests-ios.yml
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
agneszitte pushed a commit that referenced this pull request Sep 14, 2023
@mergify @Xiaoy312
@RafaelMendesRosa @jeromelaban @rafael-rosa-knowcode
[ShadowContainer] CornerRadius performance issue (backport #790) (#844)
d1c7b96 
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
Co-authored-by: Rafael Rosa <116665025+rafael-rosa-knowcode@users.noreply.github.com>
agneszitte pushed a commit that referenced this pull request Sep 14, 2023
@mergify @Xiaoy312
@RafaelMendesRosa @jeromelaban @rafael-rosa-knowcode
[ShadowContainer] CornerRadius performance issue (backport #790) (#845)
795c3c9 
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
Co-authored-by: Rafael Rosa <116665025+rafael-rosa-knowcode@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ShadowContainer] CornerRadius performance issue
5 participants
@rafael-rosa-knowcode @agneszitte @Xiaoy312 @jeromelaban @RafaelMendesRosa