Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadowContainer] CornerRadius performance issue (backport #790) #845

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 14, 2023

This is an automatic backport of pull request #790 done by Mergify.
Cherry-pick of 50eed77 has failed:

On branch mergify/bp/release/stable/4.2/pr-790
Your branch is up to date with 'origin/release/stable/4.2'.

You are currently cherry-picking commit 50eed77.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/Uno.Toolkit.RuntimeTests/Tests/ShadowContainerTests.cs
	modified:   src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.Paint.cs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   build/workflow/stage-uitests-ios.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Rafael Rosa <rafaelmendesrosa@gmail.com>
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
(cherry picked from commit 50eed77)

# Conflicts:
#	build/workflow/stage-uitests-ios.yml
@mergify mergify bot added the conflicts label Sep 14, 2023
@agneszitte agneszitte linked an issue Sep 14, 2023 that may be closed by this pull request
11 tasks
@agneszitte agneszitte merged commit 795c3c9 into release/stable/4.2 Sep 14, 2023
29 checks passed
@agneszitte agneszitte deleted the mergify/bp/release/stable/4.2/pr-790 branch September 14, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ShadowContainer] CornerRadius performance issue
3 participants