Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): manipulation canceled in uno4 & eatten by scrollable/swipable elements #266

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Jun 23, 2022

GitHub Issue (If applicable): closes unoplatform/nventive-private#363, closes #206

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

fix uno4 manipulation event-source breaking change
fix manipulation eatten by scrollable/swipable elements

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):
uno4 manipulation event-source breaking change: https://github.com/unoplatform/nventive-private/issues/349
manipulation eatten by scrollable/swipable elements (gesture interceptor): https://github.com/unoplatform/nventive-private/issues/271

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-266.eastus2.azurestaticapps.net

@jeromelaban
Copy link
Member

It would be interesting to have @sakshi173 include this in the QA Passes.

@Xiaoy312 Xiaoy312 marked this pull request as ready for review June 27, 2022 15:38
@Xiaoy312 Xiaoy312 requested review from dr1rrb and kazo0 July 20, 2022 17:00
@Xiaoy312 Xiaoy312 merged commit b98ad87 into main Jul 20, 2022
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20220623/drawer-control-fixes branch July 20, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DrawerControl doesnt work on playground.
3 participants