Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ControlExtensions and InputExtensions #287

Merged
merged 2 commits into from
Aug 24, 2022
Merged

feat: ControlExtensions and InputExtensions #287

merged 2 commits into from
Aug 24, 2022

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Aug 15, 2022 •
edited
Loading

GitHub Issue (If applicable): closes #280, closes #282

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220815/input-extensions branch from 59ec7e7 to 1d7b4f8 Compare August 15, 2022 23:23
@github-actions
Copy link

github-actions bot commented Aug 15, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 15, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220815/input-extensions branch from 1d7b4f8 to 4ee7f85 Compare August 17, 2022 13:19
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Aug 17, 2022 •
edited
Loading

note: this is still in draft,
as InputExtensions.EnterCommand will be aliased from ControlExtensions.Command
and there is support for ListView item-clicks and navigation-controls navigation to be added
^ thats done

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220815/input-extensions branch from 4ee7f85 to ff66c1c Compare August 17, 2022 17:29
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220815/input-extensions branch from ff66c1c to c8c08a1 Compare August 17, 2022 18:59
@Xiaoy312 Xiaoy312 marked this pull request as ready for review August 17, 2022 19:02
@Xiaoy312 Xiaoy312 requested a review from kazo0 August 17, 2022 19:03
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 changed the title WIP: feat: Input Extensions feat: ControlExtensions and InputExtensions Aug 17, 2022
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220815/input-extensions branch from c8c08a1 to 035dece Compare August 17, 2022 19:15
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

dr1rrb
dr1rrb reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@dr1rrb dr1rrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add XML-doc on all public members. '.md' docs files are nice, but the XML-doc is much easier to use while using those.

src/Uno.Toolkit.UI/Behaviors/ControlExtensions.cs Show resolved Hide resolved
src/Uno.Toolkit.UI/Behaviors/ControlExtensions.cs Show resolved Hide resolved
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220815/input-extensions branch from 035dece to 132c03c Compare August 22, 2022 16:02
@github-actions
Copy link

github-actions bot commented Aug 22, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-287.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit cdd407c into main Aug 24, 2022
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20220815/input-extensions branch August 24, 2022 17:29
@Xiaoy312 Xiaoy312 mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatFillion MatFillion MatFillion left review comments

@dr1rrb dr1rrb dr1rrb left review comments

@francoistanguay francoistanguay francoistanguay left review comments

@kazo0 kazo0 kazo0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Xiaoy312 @kazo0 @MatFillion @dr1rrb @francoistanguay