Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Align Loading/Loaded events with WinUI #14936

Merged
merged 79 commits into from
May 14, 2024
Merged

fix: Align Loading/Loaded events with WinUI #14936

merged 79 commits into from
May 14, 2024

Conversation

Youssef1313
Copy link
Member

Replaces #14528

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/code-generation Categorizes an issue or PR as relevant to code generation area/build Categorizes an issue or PR as relevant to build infrastructure area/automation Categorizes an issue or PR as relevant to project automation kind/documentation labels Dec 29, 2023
@Youssef1313 Youssef1313 force-pushed the lifecycle-winui branch 2 times, most recently from a8251df to 2ecb2af Compare December 29, 2023 09:22
@Youssef1313 Youssef1313 force-pushed the lifecycle-winui branch 6 times, most recently from c4051e3 to 0789127 Compare January 7, 2024 12:50
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14936/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14936/index.html

@Youssef1313 Youssef1313 force-pushed the lifecycle-winui branch 9 times, most recently from 751117e to eb86ca2 Compare January 12, 2024 13:58
@Youssef1313 Youssef1313 mentioned this pull request Jan 12, 2024
Open
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14936/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14936/index.html

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14936/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14936/index.html

@Youssef1313 Youssef1313 merged commit 314543d into unoplatform:master May 14, 2024
103 checks passed
@Youssef1313 Youssef1313 deleted the lifecycle-winui branch May 14, 2024 17:04
@kazo0
Copy link
Contributor

kazo0 commented May 28, 2024

fixes #16715
fixes #16503

@MartinZikmund
Copy link
Member

fixes #16715 fixes #16503

But how 😂 ! Are there some changes that affected iOS here @Youssef1313?

@Youssef1313
Copy link
Member Author

fixes #16715 fixes #16503

But how 😂 ! Are there some changes that affected iOS here @Youssef1313?

I don't know how 😂
It is not supposed or intended to happen. But as it is a fix not regression it's good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund left review comments

@jeromelaban jeromelaban jeromelaban left review comments

@dr1rrb dr1rrb dr1rrb approved these changes

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

Assignees

@MartinZikmund MartinZikmund

@Youssef1313 Youssef1313

Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Youssef1313 @unodevops @kazo0 @MartinZikmund @jeromelaban @dr1rrb