Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid LOH allocations in RenderTargetBitmap #14959

Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 4, 2024

GitHub Issue (If applicable): closes #14955

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jan 4, 2024
@Youssef1313 Youssef1313 force-pushed the rendertargetbitmap-unmanagedmem branch 2 times, most recently from bf7186b to f424c72 Compare January 4, 2024 13:08
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14959/index.html

@Youssef1313 Youssef1313 force-pushed the rendertargetbitmap-unmanagedmem branch from f424c72 to 133ae64 Compare January 5, 2024 08:12
@github-actions github-actions bot added platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Jan 5, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14959/index.html

@Youssef1313 Youssef1313 force-pushed the rendertargetbitmap-unmanagedmem branch from 133ae64 to ee7b543 Compare January 5, 2024 08:49
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14959/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14959/index.html

@Youssef1313 Youssef1313 force-pushed the rendertargetbitmap-unmanagedmem branch from 4bc85d9 to a937936 Compare January 14, 2024 08:44
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14959/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14959/index.html

@jeromelaban jeromelaban merged commit c69f07c into unoplatform:master Feb 1, 2024
85 checks passed
@Youssef1313 Youssef1313 deleted the rendertargetbitmap-unmanagedmem branch February 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Skia] RenderTargetBitmap improvements
3 participants