Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make Samples app use Fluent styles by default #15041

Closed
wants to merge 17 commits into from
Closed

refactor: Make Samples app use Fluent styles by default #15041

wants to merge 17 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Jan 12, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #15005

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

UWP by default

What is the new behavior?

Fluent by default

PR Checklist

Please check if your PR fulfills the following requirements:

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jan 12, 2024
@MartinZikmund MartinZikmund changed the title refactor: Make Samples app Fluent by default refactor: Make Samples app use Fluent styles by default Jan 12, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jan 17, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15041/index.html

@jeromelaban jeromelaban marked this pull request as draft February 2, 2024 14:39
MartinZikmund added a commit that referenced this pull request Mar 5, 2024
@MartinZikmund
chore: Make TeachingTips run on Fluent only until #15041 is merged
f2b8a57
MartinZikmund added a commit that referenced this pull request Mar 5, 2024
@MartinZikmund
chore: Make TeachingTips run on Fluent only until #15041 is merged
935851e
MartinZikmund added a commit that referenced this pull request Mar 6, 2024
@MartinZikmund
chore: Make TeachingTips run on Fluent only until #15041 is merged
1ca25e6
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@MartinZikmund MartinZikmund marked this pull request as ready for review March 18, 2024 13:48
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15041/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15041/index.html

@jeromelaban jeromelaban marked this pull request as draft May 14, 2024 12:07
@MartinZikmund
Copy link
Member Author

Closing in favor of #16762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run runtime tests in Fluent theme context
3 participants
@MartinZikmund @unodevops @Youssef1313