Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Samples app use fluent styles by default #16762

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Make Samples app use fluent styles by default #16762

wants to merge 42 commits into from
+676 −813

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels May 17, 2024
@MartinZikmund MartinZikmund mentioned this pull request May 17, 2024
Closed
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

ramezgerges
ramezgerges reviewed Jul 1, 2024
View reviewed changes
src/Uno.UI/UI/Xaml/UIElement.Pointers.cs
@@ -726,6 +726,7 @@ private async Task<DataPackageOperation> StartDragAsyncCore(PointerPoint pointer
var routedArgs = new DragStartingEventArgs(this, ptArgs);
PrepareShare(routedArgs.Data); // Gives opportunity to the control to fulfill the data
SafeRaiseEvent(DragStartingEvent, routedArgs); // The event won't bubble, cf. PrepareManagedDragAndDropEventBubbling
UpdateLayout(); // we need a layout cycle before a possible DragEnter just in case DragStarting causes the visual tree to change
Copy link
Contributor

@ramezgerges ramezgerges Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed in favor of #17357, which is a cleaner fix. This was meant to be a temporary line to see what works but I forgot to clean it up.

@ramezgerges ramezgerges mentioned this pull request Jul 2, 2024
Merged
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

MartinZikmund and others added 26 commits July 15, 2024 13:46
@MartinZikmund @Youssef1313
chore: Remove border from button on UI test
0b485a0
@ramezgerges @Youssef1313
chore: remove UseFluentStyles
7c276f7
@ramezgerges @Youssef1313
chore: fix When_PasswordBox_TextRevealed
b66a518
@ramezgerges @Youssef1313
chore: adjust CanOpenFlyoutByKeyboard
fe3da4b
@ramezgerges @Youssef1313
chore: adjust When_Caret_Color_DarkMode
d34d77e
@ramezgerges @Youssef1313
chore: adjust Check_Placement_All_MenuFlyout
4c0a76f
@ramezgerges @Youssef1313
fix: hyperlink foreground logic to make TestRespectHyperlinkForegroun…
f312e3f 
…d work
@ramezgerges @Youssef1313
chore: adjust When_Visibility_Changes
4b3469c
@ramezgerges @Youssef1313
fix(popup): transfer RenderTransform and Translation to the Child
2bbc743
@ramezgerges @Youssef1313
chore: fix Drag&drop in TreeView (When_TreeViewItem_Dragged_NRE)
c868dfa
@MartinZikmund @Youssef1313
chore: Formatting adjustment
f11860b
@MartinZikmund @Youssef1313
chore: Adjust the test for WinAppSDK
d38da3c
@MartinZikmund @Youssef1313
chore: Adjust for UWP build and StyleHelper
c545a79
@MartinZikmund @Youssef1313
chore: Disable failing test, adjust TB test
62e4e87
@MartinZikmund @Youssef1313
chore: Disable CornerRadius UI test (#17272)
e59b4df
@MartinZikmund @Youssef1313
chore: Disable ItemCornerRadius test on WASM (#17272)
646a96b
@MartinZikmund @Youssef1313
chore: Disable Validate_UseUWPDefaultStyles (#17272)
4a7b4e8
@MartinZikmund @Youssef1313
fix: Avoid infinite layout loop in MediaTransportControls
8c7d9e4 
Subscription to LayoutUpdated caused it to loop infinitely as it manipulated margins of inner controls, which then triggered another layout loop, which reset them again
@Youssef1313
chore: Adjust tests for fluent
94abdb4
@Youssef1313
chore: Adjust DatePicker
8d33e17
@Youssef1313
chore: Adjust
abec08a
@Youssef1313
chore: Adjust for Android
5f0f926
@Youssef1313
chore: Adjust
030633f
@Youssef1313
chore: Adjust test
8ebc4c3
@Youssef1313
chore: Adjust tests
078ad34
@Youssef1313
chore: Adjust for failing Wasm tests
9fbe173
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16762/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16762/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramezgerges ramezgerges ramezgerges left review comments

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MartinZikmund @unodevops @Youssef1313 @ramezgerges