Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TimePicker and DatePicker native flyouts closing and unload #15261

Merged
merged 8 commits into from
Jan 30, 2024
Merged

fix: TimePicker and DatePicker native flyouts closing and unload #15261

merged 8 commits into from
Jan 30, 2024

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Jan 30, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #15256, fixes #15267

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • App crashes when the DatePicker is unloaded

What is the new behavior?

  • Behavior of TimePicker and DatePicker native flyouts is more aligned with managed flyouts
  • Pickers do not throw when the control has open flyout and is unloaded
  • Unloading controls automatically closes associated flyouts

PR Checklist

Please check if your PR fulfills the following requirements:

@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Jan 30, 2024
@MartinZikmund MartinZikmund changed the title test: TimePicker and DatePicker closing and unload fix: TimePicker and DatePicker native flyouts closing and unload Jan 30, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15261/index.html

@MartinZikmund
Copy link
Member Author

@Mergifyio backport release/stable/5.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024 •
edited
Loading

backport release/stable/5.1

✅ Backports have been created

@MartinZikmund MartinZikmund mentioned this pull request Jan 30, 2024
Merged
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15261/index.html

@nventive-devops
Copy link
Contributor

The build 110625 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 59, ios: 56, ios-Snap: 812, skia-gtk-screenshots: 18, skia-wpf-screenshots: 17, wasm: 51, wasm-automated-net7.0-UWP-Default-automated: 32, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 1, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 59 changed over 1049

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Grid_Simpletwocolumnsplitgrid_Uno_UI_Samples_Content_UITests_GridTestsControl_Simpletwocolumnsplitgrid
    • Grid_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_Spacing_Adjustable_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_Spacing_Adjustable
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_NoSize_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_NoSize
    • ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • Flyouts_MenuFlyoutItem_Hierarchy_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_MenuFlyoutItem_Hierarchy
    • GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewGroupedResizable_Uno_UI_Samples_Content_UITests_GridView_GridViewGroupedResizable
    • GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest
    • ListView_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_VirtualizePanelAdaptaterIdCache_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_VirtualizePanelAdaptaterIdCache
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Slider_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Slider
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • PullToRefresh_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerHorizontalScroll_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerHorizontalScroll
    • PullToRefresh_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerNavigation_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerNavigation
    • Grid_CenteredGridinGridwithtwofixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwithtwofixedsizechildren

  • ios: 56 changed over 266

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Check_ListView_Swallows_Measure_before_scroll
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_Collapsed_State
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_Expanded_State
    • ListView_Weird_Measure_During_Arrange_after_layout
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Initial_State
    • ListView_ExpandableItem_ExpandSingleItem_Collapsed_State
    • ListView_ObservableCollection_Creation_Count_UITests_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_CreationCount
    • Check_ListView_Swallows_Measure_after_scroll
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
    • ListView_ExpandableItem_ExpandSingleItem_Initial_State
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_VirtualizePanelAdaptaterIdCache_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_VirtualizePanelAdaptaterIdCache
    • ListView_ExpandableItem_ExpandSingleItem_Expanded_State
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State

  • ios-Snap: 812 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_Uniform_Thickness_and_Small_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Small_Radius
    • Brushes_RadialGradientBrush_MUXControlsTestApp_RadialGradientBrushPage
    • Buttons_ToggleSwitch_IsEnable_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_Automated
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_DoubleAnimationClipping_SamplesApp_Windows_UI_Xaml_Clipping_DoubleAnimationClipping
    • ComboBox_ComboBox_CornerRadius_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_CornerRadius
    • ComboBox_ComboBox_Corners_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Corners
    • CommandBar_CommandBar_BackButtonTitle_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonTitle_CommandBar_Frame
    • CommandBar_CommandBar_Background_UITests_Windows_UI_Xaml_Controls_CommandBar_Background_CommandBar_Background_Frame
    • Control_BasicEnability_UITests_Shared_Windows_UI_Xaml_Enability_BasicEnability
    • Control_Button_Enabled_Control_Disabled_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_Enabled_Control_Disabled
    • Dialogs_ContentDialog_ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ContentDialogTests_ContentDialog_ComboBox
    • Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_TransformationsTests_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_TransformationsTests
    • Gesture_Recognizer_UITests_Windows_UI_Input_GestureRecognizerTests_Manipulation_Inertia_UITests_Windows_UI_Input_GestureRecognizerTests_Manipulation_Inertia
    • Grid_Grid_with_attributed_string_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_attributed_string
    • Grid_Grid_with_Fixed_Size_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Fixed_Size
    • Icons_UITests_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Monochromatic_UITests_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Monochromatic
    • Icons_UITests_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Sizing_UITests_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Sizing
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromStream_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromStream

  • skia-gtk-screenshots: 18 changed over 1097

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Pickers-CalendarView_Theming.png
    • Shapes-Offscreen_Shapes.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • MUX-WinUIProgressRingPage.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • PipsPager-PipsPagerExamples.png
    • MediaPlayerElement-Using .avi.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WinUIProgressRing_Features.png
    • Image-Image_Stretch_None.png
    • Brushes-Ellipse.png
    • ListView-ListViewSelectedItems.png
    • WinUI-PipsPagerExamples.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png

  • skia-wpf-screenshots: 17 changed over 1097

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • Pickers-CalendarView_Theming.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • ListView-ListViewSelectedItems.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • PipsPager-PipsPagerExamples.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • Transform-TransformToVisual_Translate2d.png
    • Grid-CenteredGridinGridwiththreefixedsizechildren.png
    • Image-UniformToFill100x100.png
    • Progress-WinUIProgressRingPage.png
    • WinUI-PipsPagerExamples.png

  • wasm: 51 changed over 1045

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.RefreshVisualizerPage
    • MUXControlsTestApp.NavigationViewMenuItemStretchPage
    • MUXControlsTestApp.PipsPagerExamples
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • UITests.Windows_UI_Xaml_Controls.SymbolIconTests.SymbolIcon_Generic
    • MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage
    • GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
    • MUXControlsTestApp.NavigationViewBlankPage1
    • MUXControlsTestApp.NavigationViewAnimationPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderFooter_ImplicitlyBinded
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_TextBox
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
    • UITests.Microsoft_UI_Xaml_Controls.SplitButtonTests.SplitButtonPage
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_DataTemplateSelector
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_Fill
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal

  • wasm-automated-net7.0-UWP-Default-automated: 32 changed over 1948

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_StrokeThickness_MyPolygon
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Check_CornerRadius_Border_CornerRadius=5
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_ListView_Expandable_Item_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Check_ListView_Swallows_Measure_after_scroll
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1

@MartinZikmund MartinZikmund merged commit c6f5129 into master Jan 30, 2024
93 checks passed
@MartinZikmund MartinZikmund deleted the dev/mazi/pickers-unload-closing branch January 30, 2024 17:31
@mergify mergify bot mentioned this pull request Jan 30, 2024
Merged
jeromelaban added a commit that referenced this pull request Feb 1, 2024
@jeromelaban
Merge pull request #15271 from unoplatform/mergify/bp/release/stable/…
4c7a756 
…5.1/pr-15261

fix: `TimePicker` and `DatePicker` native flyouts closing and unload and workitem attribute (backport #15261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

Assignees
No one assigned
Labels
platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform
Projects
None yet
Milestone
No milestone
5 participants
@MartinZikmund @unodevops @nventive-devops @jeromelaban @Youssef1313