Prevent PivotPanel from returning "infinite" as desired height #1546
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldebilly
added
kind/bug
carldebilly
requested review from
dr1rrb,
davidjohnoliver,
ghuntley and
jeromelaban
dr1rrb
approved these changes
Sep 13, 2019
| { | ||
| MeasureElement(child, availableSize); | ||
| if(child.DesiredSize.Height > maxHeight) | ||
| { | ||
| maxHeight = child.DesiredSize.Height; |
There was a problem hiding this comment.
Suggested change
| maxHeight = child.DesiredSize.Height; | |
| maxHeight = Math.Max(maxHeight, child.DesiredSize.Height); |
davidjohnoliver
approved these changes
Sep 14, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
Bugfix
PivotPanelwere returning theavailablesize'sHeightas desired height, which is invalid when the available size is infinite.This was causing a crash.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.