Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate disable implicit using #16679

Merged
merged 3 commits into from
May 13, 2024
Merged

fix: Validate disable implicit using #16679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b932eba
fix: Validate disable implicit using
jeromelaban May 10, 2024
acba3ab
chore: Adjust condition
jeromelaban May 10, 2024
3ebfbba
chore: adjust regression tests
jeromelaban May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build/test-scripts/run-netcore-mobile-template-tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ $projects =
@("5.2/uno52Lib/uno52Lib.csproj", @("-f", "net8.0-android"), $true, $true),
@("5.2/uno52Lib/uno52Lib.csproj", @("-f", "net8.0-maccatalyst"), $true, $true),
@("5.2/uno52Lib/uno52Lib.csproj", @("-f", "net8.0-desktop"), $true, $true),

@("5.2/uno52Lib/uno52Lib.csproj", @("-f", "net8.0-browserwasm", "-p:ImplicitUsings=disable"), $true, $true),
@("5.2/uno52Lib/uno52Lib.csproj", @("-f", "net8.0-desktop", "-p:ImplicitUsings=disable"), $true, $true),

# Default mode for the template is WindowsAppSDKSelfContained=true, which requires specifying a target platform.
@("5.2/uno52Lib/uno52Lib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.19041"), $false, $true),
Expand Down
2 changes: 1 addition & 1 deletion src/Uno.Sdk/targets/Uno.Common.Wasm.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
`DefiningProjectDirectory` is not available when used from a global itemgroup, but is
available from an target.
-->
<_RemoveWebSDKUsing Include="@(Using)" Condition="$([System.String]::Copy(%(Using.DefiningProjectDirectory)).Contains('Microsoft.NET.Sdk.Web'))" />
<_RemoveWebSDKUsing Include="@(Using)" Condition="'%(Using.DefiningProjectDirectory)'!='' AND $([System.String]::Copy(%(Using.DefiningProjectDirectory)).Contains('Microsoft.NET.Sdk.Web'))" />
<Using Remove="@(_RemoveWebSDKUsing)" />
<_RemoveWebSDKUsing Remove="@(_RemoveWebSDKUsing)"/>
</ItemGroup>
Expand Down
Loading