[iOS] Fix border thickness with corner radius set #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the clipping mask calculation when non-zero CornerRadius is set on a border. Enabled the existing Border_CornerRadius_Toggle UI test for iOS, which covers this case.
|
|
github-actions
bot
added
area/build
MatFillion
approved these changes
Mar 6, 2020
carldebilly
approved these changes
Mar 6, 2020
|
The build 12831 found UI Test snapshots differences.
|
|
Snapshot review: most of the iOS changes reflect the fix (previous shot was incorrect, new is correct), a few reveal remaining issues that will be fixed shortly |
Don't call FrameworkElement.OnBackgroundChanged() for ContentPresenter. This brings it in line with similar controls (Border, Panel) and fixes bug where a few pixels of the background would protrude from the border if BorderBrush and CornerRadius were set (corresponding sample: ContentPresenter_Background).
Restore fillMask when drawing LinearGradientBrush and ImageBrush. This is required to prevent a 1-2 pixel-thick protrusion outside the BorderBrush.
github-actions
bot
added
the
area/automation
|
The build 12833 found UI Test snapshots differences.
|
|
@Mergifyio backport release/beta/2.1 |
|
Command
|
jeromelaban
added a commit
that referenced
this pull request
Mar 11, 2020
…/pr-2750 [iOS] Fix border thickness with corner radius set (bp #2750)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the clipping mask calculation when non-zero CornerRadius is set on a border.
Enabled the existing
Border_CornerRadius_ToggleUI test for iOS, which covers this case.GitHub Issue (If applicable): fixes #2746
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):