-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix border thickness with corner radius set #2750
Conversation
Fixed the clipping mask calculation when non-zero CornerRadius is set on a border. Enabled the existing Border_CornerRadius_Toggle UI test for iOS, which covers this case.
The build 12831 found UI Test snapshots differences.
|
Snapshot review: most of the iOS changes reflect the fix (previous shot was incorrect, new is correct), a few reveal remaining issues that will be fixed shortly |
Don't call FrameworkElement.OnBackgroundChanged() for ContentPresenter. This brings it in line with similar controls (Border, Panel) and fixes bug where a few pixels of the background would protrude from the border if BorderBrush and CornerRadius were set (corresponding sample: ContentPresenter_Background).
Restore fillMask when drawing LinearGradientBrush and ImageBrush. This is required to prevent a 1-2 pixel-thick protrusion outside the BorderBrush.
The build 12833 found UI Test snapshots differences.
|
@Mergifyio backport release/beta/2.1 |
Command
|
…/pr-2750 [iOS] Fix border thickness with corner radius set (bp #2750)
Fixed the clipping mask calculation when non-zero CornerRadius is set on a border.
Enabled the existing
Border_CornerRadius_Toggle
UI test for iOS, which covers this case.GitHub Issue (If applicable): fixes #2746
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):