Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support of resources localized with region code #501

Merged
merged 1 commit into from Jan 18, 2019

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Jan 17, 2019

  • Fix resources generation support for resources localized with region code
  • Fix fallback mechanism of the Resource loader

GitHub Issue (If applicable): #493

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  1. If a resource file is added with a region code, the resource generator will either ignore it or place it in an invalid location for the Android localization file structure
  2. When a resource is missing for the current UI culture, the ResourceLoader will not fallback properly on the DefaultLanguage (if the current UI culture is fr-FR and the default language is en-US, it tries only fr-FR and fr)

What is the new behavior?

  1. File structure is now valid so Android is able to load resources by itself
  2. If the current UI culture is fr-FR and the default language is en-US, ResourceLoader will now try (in that order) fr-FR , fr, en-US and en

PR Checklist

Please check if your PR fulfills the following requirements:

Internal Issue (If applicable):
https://nventive.visualstudio.com/Umbrella/_workitems/edit/144268

@dr1rrb dr1rrb self-assigned this Jan 17, 2019
@dr1rrb dr1rrb added the kind/bug Something isn't working label Jan 17, 2019
…x the fallback mechanism of the resource loader
@dr1rrb dr1rrb merged commit 6508fe9 into master Jan 18, 2019
@dr1rrb dr1rrb deleted the dev/dr/ResourcesAndroid branch January 18, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants