Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameters in lib files #4

Open
dengeltheyounger opened this issue May 26, 2020 · 0 comments
Open

Unused parameters in lib files #4

dengeltheyounger opened this issue May 26, 2020 · 0 comments

Comments

@dengeltheyounger
Copy link

I've noticed that in the lib folder that are at least a few files that take a socklen_t parameter. Notable examples of this are sock_cmp_addr, sock_cmp_port, and sock_get_port (although, there are others).

None of these functions actually use the socklen_t parameter. Moreover, the sockaddr_in and sockaddr_in6 structs have their on sa_len member. Any idea why the author required the socklen_t parameter despite not actually using it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant