-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undefined var in html examples #3
Comments
Thanks for reporting this, fixed! |
The walk thru here: http://ozan.io/p/#/walkthrough is borked. I started by following that walk thru, but once i discovered https://github.com/oztu/p/tree/master/examples/ping-pong it became clear that things have changed. Connect takes a hash. The websocket announces new peers via 'connection' rather than 'message'. I probably have a better handle on what else has changed. :) ps. I'm having fun, thanks. |
Ah, sorry, I had fixed it on the front page, but didn't realize the problem occurred elsewhere. I'll update accordingly. |
Alright I've updated the walkthrough page as well, I still have to verify the cookbook page to make sure that's up-to-date so I'm going to keep this issue open until I do that. |
Now I feel guilty about your weekend, give my apologies to your family. :) |
I guess this is related, so I'll add it as a comment here. I'm a bit confused by the 'connection' event. What confuses me you ask? Here are the uses in the examples:
|
|
The variable onramp appears in the html examples, but it is never declared or initialized.
For example in the walkthru
The text was updated successfully, but these errors were encountered: