-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install target does not install the main binary #290
Comments
correct there is no install target defined. i dont really know how it works but im open to a PR or maybe i will look into it at some point in the future |
The current state is somewhat problematic, IMO, since it is not just that target is completely absent (which is kinda fine, at least a user will get an error or sees nothing being installed): it is present, but installs some random stuff without installing the main thing :) |
@ouwou Took a bit of time to sort this out, but I have it running now on a PowerMac in 10.6 ppc :) |
voice chat should work :^) |
Yes. IMO, it should either install everything which is chosen via configure args (and obviously, the main binary), or install nothing (leaving it to a user). The second choice is not great, since it may not be obvious, what exactly should be installed and where. For Macports, I used externally installed dependencies, so that we do not need to fetch submodules and possibly build duplicate libraries. And we handle installation manually via destroot phase in portfile. But it will be nice to have it fixed for everyone. |
The thing with packaging/installing is, that I originally wanted it to be all statically packaged and I made a sort-of proof of concept for a nonstatic .app build on #207. I currently still use that Abaddon.app approach but problem being is that I couldn't get static builds working at all and left it as is. |
@TheMorc Could you share contents of the bundle with paths? I can try reproducing it locally. |
@TheMorc In fact Macports has a portgroup which implements app packaging, I can see if that gonna work. |
@barracuda156 nothing is really that much different in the app bundle from that zipped one in the other PR, the executable doesn't really need symlinks or any lib gymnastics to get working. I just wanted it to have them packed there for the simplicity that you could download a build without building it yourself.
|
There is something very wrong with how install target is set up currently.
I have written a port for
abaddon
which uses default settings, and here is what gets installed:And indeed, main CMakeLists have nothing about installing of what they build.
Notice, the build itself is fine, I get
abaddon
in CMake build directory and it can be launched normally. But it does not get installed.The text was updated successfully, but these errors were encountered: