Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mock texts with proper messages #559

Merged
merged 7 commits into from
Oct 9, 2020
Merged

Conversation

theovier
Copy link
Collaborator

@theovier theovier commented Oct 2, 2020

Description

Reason for this PR

  • The messages in the profile and account creation were mostly mockups.

Changes in this PR

  • Replace mock texts with proper messages that should give the user a good overview over the sections.

Type of change

  • Refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend:

    • Development build
  • Backend:

    • No backend needed to test this

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

Copy link
Contributor

@tobias-wiese tobias-wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could additionally adapt the info texts in the course form as well.

CHANGELOG.md Outdated Show resolved Hide resolved
theovier and others added 4 commits October 9, 2020 15:04
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
…n.vue

Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
….vue

Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
…n.vue

Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
@theovier theovier merged commit dec7ca9 into develop Oct 9, 2020
@theovier theovier deleted the bugfix/update_info_texts branch October 9, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants