-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certificates #564
Certificates #564
Conversation
not tested
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Theo Harkenbusch <theo@harkenbusch.com>
Co-authored-by: tobias-wiese <tobiaswiese@online.de>
Co-authored-by: tobias-wiese <tobiaswiese@online.de>
Co-authored-by: tobias-wiese <tobiaswiese@online.de>
atm implemented with mock data as store.getters.certificate does not work yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not test the code on my local machine here, but as I was involved in developing most of the code anyways.
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only comments so far... Approval follows after meeting.
Description
Implements all functionality for creating certificates. Could not yet be tested with any backend, but CSR and keys work (checked with openssl too).
Tests work with experimental deployment.
Changes in this PR
Type of change (remove all that don't apply)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
OS: Windows
Browser: Chrome
Frontend: (remove all that don't apply)
Backend: (remove all that don't apply)
Checklist: (remove all that don't apply)