Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates #564

Merged
merged 43 commits into from
Nov 3, 2020
Merged

Certificates #564

merged 43 commits into from
Nov 3, 2020

Conversation

bastihav
Copy link
Collaborator

@bastihav bastihav commented Oct 5, 2020

Description

Implements all functionality for creating certificates. Could not yet be tested with any backend, but CSR and keys work (checked with openssl too).

Tests work with experimental deployment.

Changes in this PR

  • Implements API for certificate management
  • Implements methods for creating CSR and encrypting/decrypting private key

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Chrome

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this
    • deployed production build
    • deployed development build
    • deployed experimental build
    • Local build (commit hash [XXXXXXX])

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (especially for bugfixes)
  • I added corresponding unit tests (if API code)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the package.json version if this is a new release candidate (remove is it is not)
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@bastihav bastihav added the vue label Oct 5, 2020
@bastihav bastihav self-assigned this Oct 5, 2020
src/components/settings/CertificateSection.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@tobias-wiese tobias-wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test the code on my local machine here, but as I was involved in developing most of the code anyways.

src/components/modals/EncryptPrivateKeyModal.vue Outdated Show resolved Hide resolved
src/views/common/Login.vue Outdated Show resolved Hide resolved
bastihav and others added 3 commits October 14, 2020 20:43
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
@bastihav bastihav marked this pull request as ready for review October 16, 2020 07:06
Copy link
Contributor

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comments so far... Approval follows after meeting.

src/api/CertificateManagement.ts Show resolved Hide resolved
src/api/CertificateManagement.ts Show resolved Hide resolved
src/use/crypto/certificates.ts Show resolved Hide resolved
@bastihav bastihav merged commit d960976 into develop Nov 3, 2020
@bastihav bastihav deleted the feature/certificates branch November 3, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants