Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Redesign & Mobile Login #698

Merged
merged 9 commits into from
Nov 18, 2020
Merged

Login Redesign & Mobile Login #698

merged 9 commits into from
Nov 18, 2020

Conversation

theovier
Copy link
Collaborator

@theovier theovier commented Nov 17, 2020

Description

Reason for this PR

  • Login page was not suitable on mobile devices

Changes in this PR

  • Login page for mobile devices

Dependency update

  • NPM: "tailwind-heropatterns": "0.0.8",

Type of change

  • Bug fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend:

    • Development build
  • Backend:

    • No backend needed to test this

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@theovier theovier added enhancement New feature or request vue responsive visual Something visual in the user interface labels Nov 17, 2020
@theovier theovier marked this pull request as ready for review November 17, 2020 18:39
Copy link
Contributor

@tobias-wiese tobias-wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is looking very nice and clean. I did some changes though:

  • I disabled the login button based on the isInputEmpty computed (325e6c1 feel free to revert)
  • I moved the instantiation of the LoginResponseHandler into the method where it's used. I think this was a mistake we did earlier in the process (9cee01e)
  • We do not have any NotYetImplemented-page that we could show for the 'Forgot your password?' thing. I implemented a suggestion of using our toasts, that are new on develop since yesterday. With that suggestion, just a warning toast with the message 'Not yet implemented.' is shown (see screenshot). This is just a suggestion so feel free to revert abcc468 if you do not like it :)
    Screenshot:
    grafik

@theovier
Copy link
Collaborator Author

I think that is looking very nice and clean. I did some changes though:

  • I disabled the login button based on the isInputEmpty computed (325e6c1 feel free to revert)
  • I moved the instantiation of the LoginResponseHandler into the method where it's used. I think this was a mistake we did earlier in the process (9cee01e)
  • We do not have any NotYetImplemented-page that we could show for the 'Forgot your password?' thing. I implemented a suggestion of using our toasts, that are new on develop since yesterday. With that suggestion, just a warning toast with the message 'Not yet implemented.' is shown (see screenshot). This is just a suggestion so feel free to revert abcc468 if you do not like it :)
    Screenshot:
    grafik

I like the changes. I thought about adding a not-implemented page too but thought that would not be in the scope of this PR. I really dig the idea of the alert.

@theovier theovier merged commit e950623 into develop Nov 18, 2020
@bastihav bastihav deleted the bugfix/mobile_login branch November 26, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request responsive visual Something visual in the user interface vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants