-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Redesign & Mobile Login #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is looking very nice and clean. I did some changes though:
- I disabled the login button based on the
isInputEmpty
computed (325e6c1 feel free to revert) - I moved the instantiation of the
LoginResponseHandler
into the method where it's used. I think this was a mistake we did earlier in the process (9cee01e) - We do not have any
NotYetImplemented
-page that we could show for the 'Forgot your password?' thing. I implemented a suggestion of using our toasts, that are new on develop since yesterday. With that suggestion, just a warning toast with the message 'Not yet implemented.' is shown (see screenshot). This is just a suggestion so feel free to revert abcc468 if you do not like it :)
Screenshot:
I like the changes. I thought about adding a not-implemented page too but thought that would not be in the scope of this PR. I really dig the idea of the alert. |
Description
Reason for this PR
Changes in this PR
Dependency update
"tailwind-heropatterns": "0.0.8",
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
OS: Windows Mac Linux
Browser: Firefox Chrome Safari Chromium
Frontend:
Backend:
Checklist: