Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/profile picture #551

Merged
merged 64 commits into from
Oct 2, 2020
Merged

Feature/profile picture #551

merged 64 commits into from
Oct 2, 2020

Conversation

tobias-wiese
Copy link
Contributor

Description

Implements issue #497 #496

Reason for this PR

Changes in this PR

  • remove picture from account entities
  • add API for getting and updating profile pictures
  • adapt account form to allow changing the profile picture
  • add section in private profile for changing the profile picture

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Dependency updates

  • add cypress-file-upload

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Firefox Chrome

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • deployed experimental build

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (especially for bugfixes)
  • I added corresponding unit tests (if API code)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

src/components/profile/ProfilePictureSection.vue Outdated Show resolved Hide resolved
src/components/profile/ProfilePictureSection.vue Outdated Show resolved Hide resolved
src/components/profile/ProfilePictureSection.vue Outdated Show resolved Hide resolved
src/use/helpers/ProfilePictureUpdateResponseHandler.ts Outdated Show resolved Hide resolved
src/components/profile/ProfilePictureSection.vue Outdated Show resolved Hide resolved
src/components/profile/ProfilePictureSection.vue Outdated Show resolved Hide resolved
src/components/profile/ProfilePictureSection.vue Outdated Show resolved Hide resolved
bastihav and others added 9 commits October 2, 2020 16:36
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Theo Harkenbusch <Theo@Harkenbusch.com>
Co-authored-by: Theo Harkenbusch <Theo@Harkenbusch.com>
Co-authored-by: Theo Harkenbusch <Theo@Harkenbusch.com>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
@tobias-wiese tobias-wiese merged commit 0245eca into develop Oct 2, 2020
@tobias-wiese tobias-wiese added the hacktoberfest-accepted For submitting PRs for the hacktoberfest event label Oct 8, 2020
@bastihav bastihav deleted the feature/profile_picture branch November 26, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted For submitting PRs for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants