Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace profile picture placeholder in account list #518

Closed
tobias-wiese opened this issue Sep 24, 2020 · 4 comments
Closed

Replace profile picture placeholder in account list #518

tobias-wiese opened this issue Sep 24, 2020 · 4 comments
Labels

Comments

@tobias-wiese
Copy link
Contributor

  • use the profile picture API (maybe in onBeforeMounted() hook)
@tobias-wiese
Copy link
Contributor Author

As we do not want to process the images on lagom side atm, it would not be feasible to load a preview image for each user. Hence, we can remove it from the account list

tobias-wiese added a commit that referenced this issue Sep 28, 2020
@tobias-wiese tobias-wiese linked a pull request Sep 30, 2020 that will close this issue
8 tasks
@theovier
Copy link
Collaborator

As we do not want to process the images on lagom side atm, it would not be feasible to load a preview image for each user. Hence, we can remove it from the account list

Is this just temporarily or are we ditching the profile pictures in the list completely? What do you mean with "process the images", could you elaborate? Thanks!

@tobias-wiese
Copy link
Contributor Author

As we do not want to process the images on lagom side atm, it would not be feasible to load a preview image for each user. Hence, we can remove it from the account list

Is this just temporarily or are we ditching the profile pictures in the list completely? What do you mean with "process the images", could you elaborate? Thanks!

Lagom saves the original images, hence each file has up 6mb or so. Loading them for each user for a "preview" image would introduce heavy network load. Somebody said, that processing the images on the server (e.g. lower resolution for preview images) is bad practice. So, we can remove them for the moment. A possible way would be to upload a profile picture AND a preview image frontendside, but that is not part of the current design. We wanted to discuss again, why processing the image on the server should not happen.

@theovier
Copy link
Collaborator

Alright, thanks for the explanation. I guess that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants