Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit info metrics as gauges #5

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

branden
Copy link
Collaborator

@branden branden commented Mar 9, 2023

Vector emits an error and fails to scrape Prometheus metrics if they contain a metric of type info. Prior to KSM 2.8.0 all custom resource metrics were of type gauge, so this effectively reverts to that behavior specifically for info metrics.

branden@crateria kube-state-metrics % make test-unit all
GOOS=darwin GOARCH=arm64  go test --race  k8s.io/kube-state-metrics/v2 k8s.io/kube-state-metrics/v2/internal k8s.io/kube-state-metrics/v2/internal/store k8s.io/kube-state-metrics/v2/pkg/allow k8s.io/kube-state-metrics/v2/pkg/allowdenylist k8s.io/kube-state-metrics/v2/pkg/app k8s.io/kube-state-metrics/v2/pkg/builder k8s.io/kube-state-metrics/v2/pkg/builder/types k8s.io/kube-state-metrics/v2/pkg/constant k8s.io/kube-state-metrics/v2/pkg/customresource k8s.io/kube-state-metrics/v2/pkg/customresourcestate k8s.io/kube-state-metrics/v2/pkg/metric k8s.io/kube-state-metrics/v2/pkg/metric_generator k8s.io/kube-state-metrics/v2/pkg/metrics_store k8s.io/kube-state-metrics/v2/pkg/metricshandler k8s.io/kube-state-metrics/v2/pkg/optin k8s.io/kube-state-metrics/v2/pkg/options k8s.io/kube-state-metrics/v2/pkg/sharding k8s.io/kube-state-metrics/v2/pkg/util/proc k8s.io/kube-state-metrics/v2/pkg/watch k8s.io/kube-state-metrics/v2/tests/lib
?       k8s.io/kube-state-metrics/v2    [no test files]
?       k8s.io/kube-state-metrics/v2/internal   [no test files]
?       k8s.io/kube-state-metrics/v2/pkg/allow  [no test files]
ok      k8s.io/kube-state-metrics/v2/internal/store     (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/allowdenylist  (cached)
?       k8s.io/kube-state-metrics/v2/pkg/builder/types  [no test files]
?       k8s.io/kube-state-metrics/v2/pkg/constant       [no test files]
?       k8s.io/kube-state-metrics/v2/pkg/customresource [no test files]
?       k8s.io/kube-state-metrics/v2/pkg/metric_generator    [no test files]
?       k8s.io/kube-state-metrics/v2/pkg/metricshandler [no test files]
ok      k8s.io/kube-state-metrics/v2/pkg/app    (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/builder        (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/customresourcestate (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/metric (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/metrics_store  (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/optin  (cached)
ok      k8s.io/kube-state-metrics/v2/pkg/options        (cached)
?       k8s.io/kube-state-metrics/v2/pkg/util/proc      [no test files]
?       k8s.io/kube-state-metrics/v2/pkg/watch  [no test files]
ok      k8s.io/kube-state-metrics/v2/pkg/sharding       (cached)
ok      k8s.io/kube-state-metrics/v2/tests/lib  (cached)
/Library/Developer/CommandLineTools/usr/bin/make --no-print-directory ARCH=amd64 container
docker build --pull -t us.gcr.io/orchestration-build/kube-state-metrics/kube-state-metrics-amd64:v2.8.1-upbound003 --build-arg GOVERSION=1.19.6 --build-arg GOARCH=amd64 .
[+] Building 68.0s (13/13) FINISHED
 => [internal] load build definition from Dockerfile     0.0s
 => => transferring dockerfile: 37B                      0.0s
 => [internal] load .dockerignore                        0.0s
 => => transferring context: 2B                          0.0s
 => [internal] load metadata for gcr.io/distroless/stat  0.4s
 => [internal] load metadata for docker.io/library/gola  1.2s
 => [auth] library/golang:pull token for registry-1.doc  0.0s
 => [builder 1/4] FROM docker.io/library/golang:1.19.6@  0.0s
 => [internal] load build context                        0.0s
 => => transferring context: 65.69kB                     0.0s
 => CACHED [stage-1 1/2] FROM gcr.io/distroless/static:  0.0s
 => => resolve gcr.io/distroless/static:latest-amd64@sh  0.0s
 => CACHED [builder 2/4] WORKDIR /go/src/k8s.io/kube-st  0.0s
 => [builder 3/4] COPY . /go/src/k8s.io/kube-state-metr  0.7s
 => [builder 4/4] RUN make build-local                  65.4s
 => [stage-1 2/2] COPY --from=builder /go/src/k8s.io/ku  0.2s
 => exporting to image                                   0.1s
 => => exporting layers                                  0.1s
 => => writing image sha256:44478f618db59c192664b30afd4  0.0s
 => => naming to us.gcr.io/orchestration-build/kube-sta  0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
<snip>
branden@crateria kube-state-metrics % echo $?
0
branden@crateria kube-state-metrics %

This is to work around Vector's prometheus_scrape source's lack of
support for info metrics.
@branden branden merged commit 4b85dbd into upbound:main Mar 9, 2023
@branden branden deleted the info-to-gauge branch March 9, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant