-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iam-role): ignore managed_policy_arns in late init #933
fix(iam-role): ignore managed_policy_arns in late init #933
Conversation
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@turkenf @jeanduplessis please take a look. I believe we require a fix release to address this issue, as fluctuating role policies can cause problems in a production environment. |
/test-examples="examples/iam/role.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @haarchri, LGTM.
My main question is whether we should also skip late init on |
In order not to block this PR, we can handle |
Thanks for the quick fix! |
Description of your changes
description is here: #929 (comment)
skip managed_policy_arns for late init
Fixes #929
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manual: #929 (comment)
Uptest: https://github.com/upbound/provider-aws/actions/runs/6611409372