Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam-role): ignore managed_policy_arns in late init #933

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 22, 2023

Description of your changes

description is here: #929 (comment)
skip managed_policy_arns for late init

Fixes #929

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual: #929 (comment)
Uptest: https://github.com/upbound/provider-aws/actions/runs/6611409372

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
Copy link
Member Author

@turkenf @jeanduplessis please take a look. I believe we require a fix release to address this issue, as fluctuating role policies can cause problems in a production environment.

@turkenf
Copy link
Collaborator

turkenf commented Oct 23, 2023

/test-examples="examples/iam/role.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @haarchri, LGTM.

@mbbush
Copy link
Collaborator

mbbush commented Oct 23, 2023

My main question is whether we should also skip late init on inline_policy

@turkenf turkenf merged commit 2646a32 into crossplane-contrib:main Oct 24, 2023
10 checks passed
@turkenf
Copy link
Collaborator

turkenf commented Oct 24, 2023

My main question is whether we should also skip late init on inline_policy

In order not to block this PR, we can handle inline_policy in another PR if it causes problems.

@blakebarnett
Copy link

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RolePolicyAttachment.iam is detaching policies every reconciliation
4 participants