Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in documentation #220

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

mergenci
Copy link
Contributor

@mergenci mergenci commented Dec 1, 2023

Description of your changes

Fixes #214 and two other unreported broken links. There are no broken links left in the documentation.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

I manually reviewed changes by navigating the affected files on GitHub and clicking new links:

  1. Migration Guide Step 5
  2. Migration Guide Step 6
  3. Configuration: IRSA
  4. Configuration: External Secrets

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@Upbound-CLA
Copy link

Upbound-CLA commented Dec 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the fixes!

@ytsarev ytsarev merged commit e0c89d4 into upbound:main Dec 1, 2023
9 checks passed
@mergenci mergenci deleted the fix-broken-links branch December 1, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration documentation URLs are Broken
4 participants