Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

up cfg has no usefulness in Spaces-based Upbound #493

Closed
cwilhit opened this issue May 7, 2024 · 2 comments · Fixed by #527
Closed

up cfg has no usefulness in Spaces-based Upbound #493

cwilhit opened this issue May 7, 2024 · 2 comments · Fixed by #527
Assignees
@adamwg
Labels
bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story points label needs-project Needs to be added to a project board

Comments

@cwilhit
Copy link
Contributor

cwilhit commented May 7, 2024

What happened?

up cfg is a set of commands to interact with Upbound Deployment Service and git-managed configurations. This feature doesn't exist in Cloud Spaces/Connected Spaces and there's no plan of record for making the feature available there currently. In the latest releases of up, because we're breaking with backwards compat for legacy Spaces, I suggest we leave the command stub there and print an error message explaining that it's not supported in Cloud/Connected Spaces.
@cwilhit cwilhit added bug Something isn't working needs-project Needs to be added to a project board needs-epic-link Needs a link to an epic needs-points-label Needs a story points label labels May 7, 2024
@jastang
Copy link
Contributor

jastang commented May 7, 2024

should we do this in one release without warning? I'd advocate for a documented deprecation notice/period of one release and give any potential users out there that may use it for CI/automation to adjust before removing it altogether

@adamwg
Copy link
Member

adamwg commented May 10, 2024

@RedbackThomson mentioned that the latest version of the CLI doesn't work with legacy managed control planes, which is the only place where configurations are applicable. If that's true, any reason to stub the command out rather than removing it outright? Presumably any users with legacy control planes will be pinned to an older CLI version.

adamwg added a commit that referenced this issue May 13, 2024
@adamwg
Stub out the configuration command and return an error
cc721d5 
The configuration command doesn't work with Upbound Cloud Spaces or Connected
Spaces, and the CLI no longer works with Legacy Spaces, so remove the
subcommands from `up configuration` and print a message.

Fixes #493

Signed-off-by: Adam Wolfe Gordon <adam.wolfegordon@upbound.io>
@adamwg adamwg mentioned this issue May 13, 2024
Merged
3 tasks
adamwg added a commit that referenced this issue May 14, 2024
@adamwg
Stub out the configuration command and return an error
41f11a2 
The configuration command doesn't work with Upbound Cloud Spaces or Connected
Spaces, and the CLI no longer works with Legacy Spaces, so remove the
subcommands from `up configuration` and print a message.

Fixes #493

Signed-off-by: Adam Wolfe Gordon <adam.wolfegordon@upbound.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamwg adamwg

Labels
bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story points label needs-project Needs to be added to a project board
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stub out the configuration command and return an error upbound/up
3 participants
@adamwg @jastang @cwilhit