Stub out the configuration command and return an error #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cmd/up/main.go
Outdated
| @@ -105,7 +104,7 @@ type cli struct { | |||
| Space space.Cmd `cmd:"" help:"Interact with Spaces."` | |||
| Group group.Cmd `cmd:"" help:"Interact with groups inside Spaces."` | |||
| ControlPlane controlplane.Cmd `cmd:"" name:"controlplane" aliases:"ctp" help:"Interact with control planes in the current context, both in the cloud and in a local Space."` | |||
| Configuration configuration.Cmd `cmd:"" name:"configuration" aliases:"cfg" help:"Interact with configurations."` | |||
| Configuration configuration.Cmd `cmd:"" name:"configuration" aliases:"cfg" help:"Interact with configurations (deprecated)."` | |||
There was a problem hiding this comment.
I used Deprecated: as a prefix for the help in up ctp.
https://github.com/upbound/up/blob/main/cmd/up/controlplane/controlplane.go#L116-L117
|
|
||
| Flags upbound.Flags `embed:""` | ||
| func (c *Cmd) Run(ctx context.Context, p pterm.TextPrinter) error { | ||
| return errors.New("Configurations are not supported in Upbound Spaces") |
There was a problem hiding this comment.
nit: Just Upbound not Upbound Spaces. I can share a link to you about how we're changing the way we talk about the product, including naming schemes.
There was a problem hiding this comment.
Thanks, makes sense. Feels a bit confusing to just say "not supported in Upbound", since it used to be supported, so I've updated it to no longer supported in Upbound to try and make it clearer why the command still exists. Open to suggestions.
RedbackThomson
approved these changes
May 14, 2024
The configuration command doesn't work with Upbound Cloud Spaces or Connected Spaces, and the CLI no longer works with Legacy Spaces, so remove the subcommands from `up configuration` and print a message. Fixes #493 Signed-off-by: Adam Wolfe Gordon <adam.wolfegordon@upbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The configuration command doesn't work with Upbound Cloud Spaces or Connected Spaces, and the CLI no longer works with Legacy Spaces, so remove the subcommands from
up configurationand print a message.Fixes #493
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Ran the unit tests, and manually verified that
up configurationprints the expected message.