Cache latest chart with proper version on install and upgrade #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a version is not specified on uxp install or upgrade, we pull the latest stable chart and cache it without version information in the dedicated uxp chart cache. This means that if a version that was installed as the latest was subsequently installed explicitly (i.e. by providing the version), we would unnecessarily pull the chart again when it was already in the cache. This updates the pull logic to save charts pulled as latest with their appropriate version so that they can be identified in future installs. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Cleans up the docstring for pullAndLoad which used catch instead of cache. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently, when a version is not specified on uxp install or upgrade, we
pull the latest stable chart and cache it without version information in
the dedicated uxp chart cache. This means that if a version that was
installed as the latest was subsequently installed explicitly (i.e. by
providing the version), we would unnecessarily pull the chart again when
it was already in the cache.
This updates the pull logic to save charts pulled as latest with their
appropriate version so that they can be identified in future installs.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
I removed the chart cache (
rm -rf ~/.cache/up/charts), then ranup uxp install(with no version specified) and observed the proper versioned chart in the cache: