Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache latest chart with proper version on install and upgrade #100

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Cache latest chart with proper version on install and upgrade #100

merged 2 commits into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. Cache latest chart with proper version on install and upgrade 

    Currently, when a version is not specified on uxp install or upgrade, we
pull the latest stable chart and cache it without version information in
the dedicated uxp chart cache. This means that if a version that was
installed as the latest was subsequently installed explicitly (i.e. by
providing the version), we would unnecessarily pull the chart again when
it was already in the cache.

This updates the pull logic to save charts pulled as latest with their
appropriate version so that they can be identified in future installs.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
    @hasheddan
    hasheddan committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3050462 View commit details
    Browse the repository at this point in the history

  2. Fix pullAndLoad docstring 

    Cleans up the docstring for pullAndLoad which used catch instead of
cache.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
    @hasheddan
    hasheddan committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    4ddd9f7 View commit details
    Browse the repository at this point in the history