Add showMessage support to xpls and new version notifications
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- emits a message to the client informing them that a new version is available of up Signed-off-by: Taylor Thornton <thornton.tn@gmail.com>
hasheddan
reviewed
Jan 22, 2022
internal/xpls/version/version.go
Outdated
| func (i *Informer) newAvailable(local, remote string) bool { | ||
| lv, err := semver.NewVersion(local) | ||
| if err != nil { | ||
| // invalid remote version detected |
There was a problem hiding this comment.
Suggested change
| // invalid remote version detected | |
| // invalid local version detected |
should this be in error message?
internal/xpls/version/version.go
Outdated
|
|
||
| "github.com/crossplane/crossplane-runtime/pkg/logging" | ||
|
|
||
| "github.com/upbound/up/internal/version" |
There was a problem hiding this comment.
Could this be bundled into the existing version pkg? I could see this being useful for checking for a new available version in up -v :) (perhaps it should be an optional flag though so that it doesn't make an unexpected network call -- could explore in the future)
There was a problem hiding this comment.
Sure thing 👍 (I'll move it). I'll hold off on adding it to up --version for now though.
moved folded local/remote version comments into errors returned to client Signed-off-by: Taylor Thornton <thornton.tn@gmail.com>
hasheddan
approved these changes
Jan 22, 2022
Comment on lines
+47
to
+49
| type client interface { | ||
| Do(*http.Request) (*http.Response, error) | ||
| } |
There was a problem hiding this comment.
Probably wouldn't hurt for us to have a small http package eventually as we are probably doing (or will do) some of this in a variety of places 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support to
xplsfor emitting messages to the end user throughwindow/showMessage. For now, this is only used to inform the end user that a new version is available to download up.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Beyond the unit tests, I hardcoded my version locally to "v0.5.0" and confirmed that I received the following pop-up:
