Add Azure support to up space billing get + provider-generic refactor
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkmuggle
approved these changes
Aug 11, 2023
| "github.com/upbound/up/internal/usage/model" | ||
| ) | ||
|
|
||
| var EOF = event.EOF |
There was a problem hiding this comment.
Seems like this error should be a common error?
There was a problem hiding this comment.
I'm not sure what you mean, can you elaborate?
This refactors the GCP implementation of `up space billing get` to use a report function that is shared with other providers.
This refactors the AWS implementation of `up space billing get` to use a report function that is shared with other providers.
branden
force-pushed
the
space-billing-get-azure
branch
from
6387b31
to
98a2920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds support for Azure blob storage to
up space billing get. It also refactors the GCS and S3 implementations to use provider-generic code for generating the report.Other things worth noting:
This is a big PR, so see commits for logical groupings of changes.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
I ran
up space billing getagainst sample data with each storage provider. I'll update this with more detail shortly.