up/profile: check for Spaces on 'up profile set space' #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
force-pushed
the
sttts-spaces-check
branch
from
270791f
to
01e964d
Compare
branden
approved these changes
Oct 31, 2023
cmd/up/profile/set_test.go
Outdated
| }, | ||
| }, | ||
| "KubeClientError": { | ||
| reason: "There is no upbound/mxe-controller in the cluster.", |
There was a problem hiding this comment.
nit: This string describes a different test case.
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.com>
sttts
force-pushed
the
sttts-spaces-check
branch
from
01e964d
to
dffdbb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We check that there is a upbound-system/mxe-controller deployment.
Based on #405
Follow-up of #400.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
up profile set spaceagainst a Space and against a non-Space kube cluster