fix(spaces): Allow ctrl+c while running up space init #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sttts
reviewed
Oct 30, 2023
sttts
reviewed
Oct 30, 2023
sttts
approved these changes
Oct 31, 2023
|
Looks great! 🚢 it. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Allows using ctrl+c to interrupt the
up space initcommand to allow stopping the installation without needing to kill the process viakill -9.Note: this does not allow for re-initialization of the space, killing the process or using ctrl+c could result in the space being in a unstable state. It'll be a bit of work to make the
up space initrerunnable/idempotent.Fixes https://github.com/upbound/mxe/issues/257
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
manually running
up space initthen using ctrl+c to exit the process while prereqs are installing.