Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes. #411

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

chrishalbert
Copy link
Contributor

@chrishalbert chrishalbert commented Jan 22, 2024

Description of your changes

This simply removes outdated docs.

Fixes #410

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

I went to the contribution markdown and no longer saw the text.

@Upbound-CLA
Copy link

Upbound-CLA commented Jan 22, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Chris Halbert <christopher.halbert@gmail.com>
@@ -13,33 +13,3 @@ make submodules

The rest is just a usual Golang CLI project where you can find the executables
under `cmd` folder.

## Release Process
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrishalbert 👋 - thanks for the submission. I think we still want the release process documented, we may just need to update the outdated link for crossplane 👍


## Release Process

This is a slimmed-down version of the release process described [here](https://github.com/crossplane/crossplane/blob/master/contributing/release-process.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the release process was moved over here https://github.com/crossplane/release. This PR may just boil down to updating that reference with the new URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on - I should know better than to assume - the cardinal sin of the developer 😄 I updated the URL accordingly. Thanks for the guidance @tnthornton !

@tnthornton tnthornton merged commit 76558fa into upbound:main Jan 23, 2024
6 checks passed
@tnthornton tnthornton changed the title Remove release notes. Update release notes. Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove release notes and reference to documentation.
3 participants