Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare Control Planes: allow for creating control planes without a config #414

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

darkmuggle
Copy link
Contributor

Description of your changes

Allow for creating a control plane without a configuration for Cloud.

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Tested locally:

minerva:~/src/up $ up ctp create -a upbound bh-horcrux --configuration-name=voldemort-prod
bh-horcrux created
minerva:~/src/up $ up ctp create -a upbound bh-darkarts
bh-darkarts created
minerva:~/src/up $ up ctp list -a upbound
NAME               ID                                     STATUS   CONFIGURATION            CONFIGURATION STATUS
bh-horcrux         7b25c5a7-ef21-41fd-972c-15e8512b3784   ready    voldemort-prod           installationQueued
bh-darkarts        fb8dc677-903b-4b17-bfc2-0bf4eb5976aa   ready    n/a                      n/a

Copy link
Contributor

@branden branden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go.mod just needs an update to remove your override for the up-sdk-go location.

go.mod Outdated Show resolved Hide resolved
@branden branden merged commit 38a5d27 into upbound:main Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants