Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to wait for PackageRevisions to be healthy #422

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tnthornton
Copy link
Member

Description of your changes

We've had some internal reports of migration not working, with what appears to be a race between attempting to apply resources prior to the APIs being available. This changeset adds a step to wait for the various PackageRevisions to be healthy before moving on.

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Taylor Thornton <thornton.tn@gmail.com>
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this enhancement ;) it's very missleading that Providers,Functions, Configurations Healthy / Installed when the Revisions Not in this Status ..

@tnthornton tnthornton merged commit b7e7360 into upbound:main Feb 1, 2024
6 checks passed
@turkenh
Copy link
Member

turkenh commented Feb 5, 2024

Thanks for the PR @tnthornton 🙌

it's very missleading that Providers,Functions, Configurations Healthy / Installed when the Revisions Not in this Status ..

I couldn't reproduce this with Crossplane v1.14 but able to reproduce with Crossplane 1.13.
So, the good news is this is something already fixed in the latest version presumably with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants