Allow repeated ctp connects #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
force-pushed
the
sttts-multiple-connects
branch
from
88cf933
to
ebe4453
Compare
AlainRoy
reviewed
Feb 28, 2024
cmd/up/controlplane/connect.go
Outdated
| @@ -62,9 +62,18 @@ func (c *connectCmd) Run(ctx context.Context, p pterm.TextPrinter, upCtx *upboun | |||
| } | |||
|
|
|||
| // Check if the fs kubeconfig is already pointing to a control plane and return early if so. | |||
There was a problem hiding this comment.
Nit: I think this comment is now wrong.
AlainRoy
approved these changes
Feb 28, 2024
cmd/up/controlplane/connect.go
Outdated
| if err := clientcmd.ModifyConfig(clientcmd.NewDefaultClientConfigLoadingRules(), kubeConfig, false); err != nil { | ||
| return err | ||
| } | ||
| p.Printfln("Switched back to context %q.", oldContext) |
There was a problem hiding this comment.
I wonder if this will be confusing for a user. If I'm reading this correctly, they'll see two messages in a row:
Switched back to context
Current context set to
That looks confusing to me. Do you agree?
There was a problem hiding this comment.
fixed. Not 100% sure which is better though.
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.com>
sttts
force-pushed
the
sttts-multiple-connects
branch
from
ebe4453
to
397a8d2
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.com>
sttts
force-pushed
the
sttts-multiple-connects
branch
from
fee182d
to
4ef7aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the full fix of #401.