connect fixes #461
Merged
connect fixes #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalanche123
force-pushed
the
connect-fixes
branch
from
cff9003
to
3012e30
Compare
cbuto
approved these changes
Apr 12, 2024
cmd/up/space/attach.go
Outdated
| if (space.Name != "" && space.Name != name) || space.Namespace != ns { | ||
| attachSpinner.UpdateText("Continue? (Y/n)") | ||
| if err := warnAndConfirm( | ||
| `Space "%s/%s" is currently connected to Upbound Console, would you like to disconnect it first?`+"\n\n"+ |
There was a problem hiding this comment.
maybe something like:
Space "<space name>" is currently connected to the Upbound Console, by continuing the current Space will be removed and this Space will be attached as "<space name>". Would you like to continue?
Co-authored-by: Casey Buto <casey.buto@upbound.io>
avalanche123
force-pushed
the
connect-fixes
branch
from
ba5d79f
to
c78a197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes upbound/connect#179
Additional flows that are enabled by this PR:
Detach space when no connect configmap exists in the space cluster but space name is specified.
This would previously exit without doing anything, instead the flow is now:
Attach a space that is currently attached under a different name.
Previously this flow would create a new space in Upbound console and leave the old Space quietly broken.
The new behavior is as follows:
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Ran the attach/detach multiple times, see description.