Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRUD on control planes within group scope #506

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix CRUD on control planes within group scope #506

merged 1 commit into from
May 8, 2024

Conversation

RedbackThomson
Copy link
Member

Description of your changes

Fixes #503

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

$ up ./default
Kubeconfig context "kind-spaces-1.4" switched to: Upbound /kind-spaces-1.4/default/
$ up ctp list
GROUP     NAME            CROSSPLANE    SYNCED   READY   MESSAGE   AGE
default   controlplane1   1.14.8-up.1   True     True              141m

@RedbackThomson RedbackThomson marked this pull request as ready for review May 8, 2024 21:35
@RedbackThomson RedbackThomson merged commit 69a3c66 into upbound:main May 8, 2024
7 checks passed
@RedbackThomson RedbackThomson deleted the fix-ctp-cmd-scope branch May 8, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuto cbuto cbuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

up ctp list: cannot view control planes when at a group scope
2 participants
@RedbackThomson @cbuto