ctx: Show unselectable items for unreachable Spaces #555
Conversation
Avoid the surprise of seeing different Spaces in the console vs. `up ctx` by listing unreachable items for Spaces that are unreachable or for which we failed to find the ingress. Sort these items to the end of the list so that all the selectable items are at the top. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
cmd/up/ctx/navigation.go
Outdated
| func (s sortedItems) Less(i, j int) bool { | ||
| itmI := s[i].(item) | ||
| itmJ := s[j].(item) | ||
|
|
||
| // Sort unselectable items last. | ||
| if itmI.notSelectable && !itmJ.notSelectable { | ||
| return false | ||
| } | ||
| if !itmI.notSelectable && itmJ.notSelectable { | ||
| return true | ||
| } | ||
|
|
||
| return s[i].(item).text < s[j].(item).text | ||
| } |
There was a problem hiding this comment.
I'm not sure this is something we always want to commit to? There's a chance we'd want to put a header label, or a separator element, midway through the list and this would conflict?
Wdyt about, when we create the list of items, we have a second list of unreachable items. Then before returning the full list, we append the unreachable ones at the end?
There was a problem hiding this comment.
Yeah, I had the same thought but discovered that this worked for all the current uses of sortedItems. I like the idea of making the ordering explicit in in Items() instead - updated to do that. As these lists get more complex we might think about adding more explicit structure to them so each Items() method doesn't have to do the same append+sort+append dance.
Sort unselectable items separately
Description of your changes
Avoid the surprise of seeing different Spaces in the console vs.
up ctxby listing unreachable items for Spaces that are unreachable or for which we failed to find the ingress. Sort these items to the end of the list so that all the selectable items are at the top.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Manual testing with organizations that have many unreachable Spaces. Also tested the other menus that may have unselectable items to make sure it all looks good.