Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yaml) Allow specifying file path as an URL #360

Merged
merged 2 commits into from
Nov 11, 2021
Merged

fix(yaml) Allow specifying file path as an URL #360

merged 2 commits into from
Nov 11, 2021

Conversation

dduportal
Copy link
Contributor

Fix #357

This PRs allow specifying Yaml file path as URLs.

Test

To test this pull request, you can run the following commands:

go build -o ./dist/updatecli && ./dist/updatecli diff --config ./examples/updateCli.generic/yaml.yaml

Additional Information

  • Introduced a New method to create a Yaml object
  • Separate YamlSpec from Yaml objects to allow injection for unit testing/mocking + easier feature upgrades
  • Use the same strategy as the file resource by adding a Read() method
  • Updated examples to provide more cases

@dduportal dduportal added bug Something isn't working resource-yaml Resource of kind YAML source labels Nov 11, 2021
olblak
olblak previously approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup, excepted a minor question, everything look good to me

@dduportal
chore(examples) update examples for shell and yaml to show more cases
1c86c24 
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
fix(yaml) Allow specifying file path as an URL
cd4be70 
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

@olblak if the proposal is ok for you, can I let you approve and merge?

@dduportal dduportal mentioned this pull request Nov 11, 2021
Merged
@olblak olblak merged commit 349bd59 into updatecli:main Nov 11, 2021
@dduportal dduportal deleted the gh-357 branch November 12, 2021 05:58
@dduportal dduportal mentioned this pull request Nov 12, 2021
Merged
@dduportal dduportal added this to the 0.14.1 milestone Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olblak olblak olblak left review comments

Assignees
No one assigned
Labels
bug Something isn't working resource-yaml Resource of kind YAML source
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

[yaml] error when the "file" key is an URL
2 participants
@dduportal @olblak