fix(yaml) allow condition without a source input value #362

dduportal · 2021-11-11T18:49:19Z

Depends on #360

This PR ensures that a condition where the input source value is provided uses this value instead of failing.

Test

To test this pull request, you can run the following commands:

go build -o ./dist/updatecli && ./dist/updatecli diff --config ./examples/updateCli.generic/yaml.yaml

Added unit tests for yaml condition (coverage of 100% for this source file)
Factorized code in yaml condition to ensure the same behavior between SCM and non SCM
Ensure that logging is reusing the constants for the unicode emojis

olblak · 2021-11-11T21:34:26Z

@dduportal they are now file conflict

olblak

It looks good to me when merge conflict are resolved

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

dduportal · 2021-11-12T06:02:42Z

Rebased :) Sorry, I'm used to full "rebase and merge" + "rebase branch" which creates conflicts with merge commits. I'll also update the other PR

dduportal added bug Something isn't working condition Modify condition resource resource-yaml Resource of kind YAML labels Nov 11, 2021

dduportal requested a review from olblak November 11, 2021 18:49

dduportal force-pushed the gh-358 branch from 0e75a80 to 359457e Compare November 11, 2021 20:18

dduportal mentioned this pull request Nov 11, 2021

fix(yaml) specifying a value takes precedence over the source input #363

Merged

olblak requested changes Nov 11, 2021

View reviewed changes

fix(yaml) allow condition without a source input value

40e9c20

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

dduportal force-pushed the gh-358 branch from 359457e to 40e9c20 Compare November 12, 2021 06:01

dduportal requested a review from olblak November 12, 2021 06:01

dduportal merged commit aba41b5 into updatecli:main Nov 12, 2021

dduportal deleted the gh-358 branch November 12, 2021 06:49

dduportal added this to the 0.14.1 milestone Nov 13, 2021