fix(yaml) specifying a value takes precedence over the source input #363

dduportal · 2021-11-11T21:27:52Z

Fix #359 .

Depends on #360 and #362

Test

To test this pull request, you can run the following commands:

go build -o ./dist/updatecli && ./dist/updatecli diff --config ./examples/updateCli.generic/yaml.yaml

Added unit tests for yaml target (not complete coverage: Yaml encoder mocking ain't easy)
Factorized code in yaml target to ensure the same behavior between SCM and non SCM
Ensure that logging is reusing the constants for the unicode emojis

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

olblak

:

dduportal requested a review from olblak November 11, 2021 21:27

dduportal added bug Something isn't working resource-yaml Resource of kind YAML target Related to updatecli target labels Nov 11, 2021

dduportal force-pushed the gh-359 branch from 9dfe791 to 36c8c43 Compare November 12, 2021 06:05

fix(yaml) specifying a value takes precedence over the source input

4f3bf35

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

dduportal force-pushed the gh-359 branch from 36c8c43 to 4f3bf35 Compare November 12, 2021 06:49

olblak approved these changes Nov 12, 2021

View reviewed changes

olblak merged commit 78cba63 into updatecli:main Nov 12, 2021

dduportal mentioned this pull request Nov 13, 2021

fix(git-generic) Ensure that git add works with absolute file paths #368

Merged

dduportal added this to the 0.14.1 milestone Nov 13, 2021

dduportal deleted the gh-359 branch November 17, 2021 18:52