-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(maven) factorize metadata into a mavenmetadata
package + apply code conventions for plugin
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
chore(maven) refactor plugin to follow code convention
chore(maven) factorize metadata into a Jan 23, 2022
mavenmetadata
package + apply code conventions for plugin
dduportal
added
condition
Modify condition resource
resource-jenkins
Resource of kind Jenkins
resource-mavenrepository
Resource of kind Maven Repository
source
and removed
resource-jenkins
Resource of kind Jenkins
labels
Jan 23, 2022
dduportal
force-pushed
the
chore/refactor-maven
branch
from
January 24, 2022 08:03
99308a0
to
af853ad
Compare
olblak
reviewed
Jan 24, 2022
olblak
reviewed
Jan 24, 2022
olblak
reviewed
Jan 24, 2022
olblak
reviewed
Jan 24, 2022
dduportal
force-pushed
the
chore/refactor-maven
branch
from
January 24, 2022 20:25
38cf447
to
f64290b
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…kage and use it for maven plugin Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…ts + improve logging Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/refactor-maven
branch
from
January 29, 2022 08:50
f64290b
to
fcf4ec6
Compare
PR ready with your last feedbacks (and blocking #482). |
lemeurherve
reviewed
Jan 29, 2022
lemeurherve
reviewed
Jan 29, 2022
lemeurherve
reviewed
Jan 29, 2022
lemeurherve
previously approved these changes
Jan 29, 2022
Signed-off-by: Damien Duportal <damien.duportal@gmail.com> (cherry picked from commit 0ade3f4e4f74032608da2741b45ea1b0995a14e0)
dduportal
force-pushed
the
chore/refactor-maven
branch
from
January 29, 2022 11:42
408d82a
to
f4d3155
Compare
Thanks for the review @lemeurherve ! PR rebased with your proposal |
lemeurherve
approved these changes
Jan 29, 2022
Since this PR is labelled as Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
condition
Modify condition resource
resource-mavenrepository
Resource of kind Maven Repository
source
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of the maven plugin to allow continuing the work in #412.
No functionnal changes (hence the chore) label.
It introduces the following changes:
maven
andjenkins
to decouplemaven
(exports aSpec
object and aNew(spec)
constructor methodTest
To test this pull request, you can run the following commands:
go build -o ./dist/updatecli && ./dist/updatecli diff --config examples/updatecli.generic/maven.yaml make test-e2e
Additional Information
Jenkins plugin is the next to be refactored. Almost there \o/