Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maven) factorize metadata into a mavenmetadata package + apply code conventions for plugin #481

Merged
merged 6 commits into from
Jan 29, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jan 23, 2022

This PR is a refactor of the maven plugin to allow continuing the work in #412.
No functionnal changes (hence the chore) label.

It introduces the following changes:

  • Update the maven example + add it to the end 2 end testing framework
  • Moved the mavenmetadata logic into its own package + use it on both maven and jenkins to decouple
  • Apply code conventions for the plugin maven (exports a Spec object and a New(spec) constructor method

Test

To test this pull request, you can run the following commands:

go build -o ./dist/updatecli && ./dist/updatecli diff --config examples/updatecli.generic/maven.yaml
make test-e2e

Additional Information

Jenkins plugin is the next to be refactored. Almost there \o/

@dduportal dduportal changed the title chore(maven) refactor plugin to follow code convention chore(maven) factorize metadata into a mavenmetadata package + apply code conventions for plugin Jan 23, 2022
@dduportal dduportal marked this pull request as ready for review January 23, 2022 21:39
@dduportal dduportal added condition Modify condition resource resource-jenkins Resource of kind Jenkins resource-mavenrepository Resource of kind Maven Repository source and removed resource-jenkins Resource of kind Jenkins labels Jan 23, 2022
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…kage and use it for maven plugin

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…ts + improve logging

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

PR ready with your last feedbacks (and blocking #482).

lemeurherve
lemeurherve previously approved these changes Jan 29, 2022
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
(cherry picked from commit 0ade3f4e4f74032608da2741b45ea1b0995a14e0)
@dduportal
Copy link
Contributor Author

Thanks for the review @lemeurherve !

PR rebased with your proposal

@dduportal
Copy link
Contributor Author

Since this PR is labelled as chore (e.g. no functionnal change), and that it has been reviewed with only minor elements, I'll put it as auto-merge with squash.

Thanks folks!

@dduportal dduportal enabled auto-merge (squash) January 29, 2022 11:47
@dduportal dduportal merged commit f6981b6 into updatecli:main Jan 29, 2022
@dduportal dduportal deleted the chore/refactor-maven branch January 29, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore condition Modify condition resource resource-mavenrepository Resource of kind Maven Repository source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants