fix(jenkins) refactor (apply code conventions) plugin to fix changelog output #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
force-pushed
the
chore/refactor-jenkins
branch
4 times, most recently
from
614670e
to
8ffdb37
Compare
dduportal
added
bug
dduportal
changed the title
dduportal
force-pushed
the
chore/refactor-jenkins
branch
2 times, most recently
from
45951ed
to
30aca7c
Compare
|
PR rebased since #481 has been merged. For this PR, I'll wait for both your approval before merging, because it fixes a behavior :) |
dduportal
force-pushed
the
chore/refactor-jenkins
branch
2 times, most recently
from
fb7b268
to
97863e0
Compare
|
Ping @olblak I would like to have this in 0.19.0 |
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
… pages Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…code Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/refactor-jenkins
branch
from
97863e0
to
0555a68
Compare
olblak
reviewed
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #481 (need rebase once merged).
Fix #480.
This PR is a refactor of the jenkins plugin to allow continuing the work in #412.
It introduces the following changes:
mavenmetadatapackage + apply code conventions for plugin #481 (hence the dependency)"github.com/Masterminds/semver/v3"library, like in theversionpackageTest
To test this pull request, you can run the following commands:
go build -o ./dist/updatecli && ./dist/updatecli diff --config examples/updatecli.generic/jenkins.yamlAdditional Information
N.A.