Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card settings vs position #20

Closed
naps62 opened this issue Jan 30, 2015 · 3 comments · Fixed by #22
Closed

Card settings vs position #20

naps62 opened this issue Jan 30, 2015 · 3 comments · Fixed by #22

Comments

@naps62
Copy link
Contributor

naps62 commented Jan 30, 2015

The documents state that a card entity has a position attribute. But instead, the current JSON I'm getting has a settings attribute, which in turn has position and starred

Which one of these is the correct one?
@jrpereira
Copy link
Contributor

The position is within the settings attribute, it's a documentation mismatch, needs to be corrected.

Feel free to send a PR to fix any documentation issues you find or if you have any suggestions for clarity!

@naps62
Copy link
Contributor Author

naps62 commented Jan 30, 2015

Sure, I can do that. I just had to be sure of which was the outdated one, the docs or the API

@nunorafaelrocha nunorafaelrocha mentioned this issue Jan 30, 2015
Merged
@nunorafaelrocha
Copy link
Contributor

I've just submitted a PR to fix the documentation about this issue.

@fixe fixe closed this as completed in #22 Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cards object seegno-forks/api
3 participants
@naps62 @jrpereira @nunorafaelrocha